sdedic opened a new pull request, #8707:
URL: https://github.com/apache/netbeans/pull/8707

   A followup to #8703 that I couldn't deliver on time before it was merged. 
The culprit for the OOM was that the introspection included static properties 
of the dumped objects. These values are not (still) needed and should they be 
provided, some tweaks should be implemented to somehow handle class-based enums 
like `JvmVendorSpec`.
   
   The OOM happened since from a reference to `JvmVendorSpec.ADOPTIUM`, all its 
static fields were dumped, so `ADOPTOPENJDK`. From `ADOPTOPENJDK`, `ADOPTIUM` 
was avoided, but all others were dumped (except ADOPTIUM and ADOPTOPENJDK). And 
so on. When it went back to root `JvmVendorSpec.ADOPTIUM`, and to the next 
sibling `AMAZON`, all statics except these two were dumped. The same for each 
of the fields as a root. If I count well, it is `13! * 13` items in total, 
which seems sufficient for OOM.
   
   This PR reverts @mbien exclusion of `vendor` (not needed any more) and 
avoids static field dumps, which will cover mor cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to