mbien commented on code in PR #8715:
URL: https://github.com/apache/netbeans/pull/8715#discussion_r2256801180
##########
extide/gradle/netbeans-gradle-tooling/src/main/java/org/netbeans/modules/gradle/tooling/NetBeansRunSinglePlugin.java:
##########
@@ -76,13 +77,16 @@ private void configureJavaExec(Project project, JavaExec
je) {
je.setArgs(asList(project.property(RUN_SINGLE_ARGS).toString().split(" ")));
}
if (project.hasProperty(RUN_SINGLE_JVM_ARGS)) {
+ // if `project' was as an implicit reference in
CommandLineArgumentProvider, it would break configuration cache
+ // requirements - leads to a warning + failed build after run.
+ List<String> jvmArgs =
asList(project.property(RUN_SINGLE_JVM_ARGS).toString().split(" "));
Review Comment:
Should the anonymous class (`CommandLineArgumentProvider`) be converted into
a private static inner class, with a note that it must stay static?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
