eirikbakke commented on PR #8589: URL: https://github.com/apache/netbeans/pull/8589#issuecomment-3193842495
Thanks for checking! I think for GNOME we should probably prefer to use the official fractional scaling support. Users with HiDPI displays may have the incentive to upgrade to the latest version in any case. What will this PR's version of the launcher do on GNOME? For KDE I can see the benefit of the flatlaf.uiScale trick, even if it's imperfect. I just hope we won't start littering the NetBeans codebase with "adjust size for flatlaf.uiScale" patches. I do share Neil's concern that the launcher is getting a bit complex at this point. It's hard to test the various settings and configurations thoroughly. An alternative to actually changing the settings automatically is to print suggestions on the terminal. E.g. * "We see you are running fractional scaling on KDE; consider setting flatlaf.uiScale in netbeans.conf." * "We see you are running fractional scaling on an older GNOME version; consider upgrading to GNOME 48." Overall I'm somewhat neutral on the pros and cons of the patch. I'll let others chime in... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
