matthiasblaesing commented on PR #8758: URL: https://github.com/apache/netbeans/pull/8758#issuecomment-3217248733
- `j2ee.jboss4` is not built - `javaee.wildfly`: Credentials are not a problem here as they are read, not written - the change in `ActonsUtil` does not change the outcome - debugger might or might not be a problem, but unless proven, changing just because is not good enough - SQL injection is not a problem here, as name is not controlled by attacker, but by the DB owner and then an attack would be against the DB, I don't see a vector here. This might be a valid patch, but would need to be split out and would then only be a bugfix - the change in `MacProvider` aund `SecurityLibrary` looks sane, but needs to be split out - the change in `Win32Protect` might also make sense If you want to get any of this in, ensure, that it does not read like being done by a robot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
