mbien commented on code in PR #39:
URL: https://github.com/apache/netbeans-jackpot30/pull/39#discussion_r2296264067
##########
.github/workflows/main.yml:
##########
@@ -45,12 +45,19 @@ jobs:
- name: Set up Ubuntu dependencies
run: |
- sudo apt install openjdk-11-jdk openjdk-17-jdk openjdk-21-jdk
+ sudo apt update
+ sudo apt install openjdk-17-jdk openjdk-21-jdk
+
+ - name: Set up latest JDK 24 from jdk.java.net
+ uses: oracle-actions/setup-java@v1
+ with:
+ website: jdk.java.net
+ release: 24
Review Comment:
```yaml
- name: Set up latest JDK 24
uses: actions/setup-java@v5
with:
distribution: 'oracle'
java-version: '24'
```
its better to avoid third party actions, since those would have to be
version-pinned and managed via dependabot like we do in the `/netbeans` repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
