wrprice opened a new pull request, #8810:
URL: https://github.com/apache/netbeans/pull/8810
Based on feedback on #8797, upgrade netbeans-gradle-tooling version of
Gradle from 7.4 to 8.11.1. There are no expected functional changes.
The 8.11.1 version was chosen as the latest _patch_ of the **earliest
version** that includes API methods that overlap between those in Gradle 7/8
and what is available in Gradle 9.0.0. The strategy is to leverage javac
compile-time validation on the code path closest to the current Gradle version
(optimistically forward-compatible?), and use reflection only when necessary
for compatibility with older versions.
Changes include:
- Gradle wrapper JAR filename changed upstream, when unpacking the Gradle
distribution zip
- Inverted GradleInternalAdapter subclass relationship: was specialized for
7.6+, now specialized for versions earlier than 7.6
- See comment in NbProjectInfoBuilder::detectConfigurationArtifacts for a
fun javac bug
- Changed `sinceGradleOrDefault` to take ExeptionCallable as the fallback
argument instead of a simple Supplier, so that the exception handling and
sneakyThrows behavior can work for the fallback (e.g. when the fallback uses
reflection) instead of only for the affirmative path.
I updated the license files (hopefully correctly!). The previously
checked-in Gradle notice file in the external dir was empty, but now it matches
the NOTICE file extracted from the new distribution zip.
cc: @mbien @lkishalmi
---
**^Add meaningful description above**
<details open>
<summary>Click to collapse/expand PR instructions</summary>
By opening a pull request you confirm that, unless explicitly stated
otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache
License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and
email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more
information.
If you're a committer, please label the PR before pressing "Create pull
request" so that the right test jobs can run.
### PR approval and merge checklist:
1. [ ] Was this PR [correctly
labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)),
did the right tests run? When did they run?
2. [ ] Is this PR
[squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
3. [ ] Are author name / email address correct? Are
[co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line)
correctly listed? Do the commit messages need updates?
3. [ ] Does the PR title and description still fit after the Nth iteration?
Is the description sufficient to appear in the release notes?
If this PR targets the delivery branch: [don't
merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery).
([full wiki
article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
