neilcsmith-net commented on PR #8407: URL: https://github.com/apache/netbeans/pull/8407#issuecomment-3268056666
> serialization was one of my concerns, I don't know what yours was since you didn't mention it yet. I've mentioned a few, one of which I think Eirik also mentioned, here and in the Slack conversation on this, as well as my PR. I'm not sure how serialization is going to be any more or less broken by int values. And anything relying on serialized dialog values is probably a little suspect already. > > API compliant Set or identity Set? 😄 > > any collection. We do not know where those keys are used. They're already equal, so any collection based on equality should behave the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
