mbien commented on code in PR #8798:
URL: https://github.com/apache/netbeans/pull/8798#discussion_r2347165452


##########
ide/projectui/src/org/netbeans/modules/project/ui/resources/layer.xml:
##########
@@ -130,6 +130,14 @@
         </folder>
     </folder>
 
+    <folder name="Favorites">
+        <file name="NetBeansProjects.shadow">

Review Comment:
   I checked and it would rename the virtual file without the display name.
   
   the current `Home` node registration is:
   
   
https://github.com/apache/netbeans/blob/3860d48919661e9f62a93e77cd5599f52716e634/platform/favorites/src/org/netbeans/modules/favorites/resources/layer.xml#L24-L31
   
   renaming `Home` using NB 27 works, but if we would render the display name 
(e.g `HOME42`), it would no longer make the update visible and it will keep 
showing `HOME42`.
   
   Changing the impl might be a bit too risky for the scope of this PR - who 
knows what relied on this. I suppose platform applications could remove the 
item via their layer somehow?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to