matthiasblaesing commented on PR #8848: URL: https://github.com/apache/netbeans/pull/8848#issuecomment-3335557138
@jherkel I have a counter suggestion: Shouldn't moving the `updateRecentConnectionsList` call into `connectTo` before the early return if it is already connected solve the problem without introducing potentially problematic/unwanted side effects? While closing connection on deletion might be acceptable, the two actions don't need to be connected. Referring to my example from the sql editor: removing an entry from SQL history does not erase it from the point where it was inserted from history. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
