eirikbakke commented on code in PR #8189:
URL: https://github.com/apache/netbeans/pull/8189#discussion_r2426825697
##########
ide/db/src/org/netbeans/modules/db/util/DriverListUtil.java:
##########
@@ -404,6 +434,8 @@ public static List<JdbcUrl> getJdbcUrls(JDBCDriver driver) {
for (JdbcUrl url : templateUrls) {
if (url.getClassName().equals(driver.getClassName())) {
JdbcUrl newurl = new JdbcUrl(url, driver);
+
newurl.setUsernamePasswordDisplayed(url.isUsernamePasswordDisplayed());
+
newurl.setDatabaseFileValidator(url.getDatabaseFileValidator());
Review Comment:
There isn't a dedicated constructor for setting these particular fields. I
figured it was cleaner to use the explicit setters than to add a constructor
with a long list of parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
