juanotto commented on code in PR #22:
URL: 
https://github.com/apache/netbeans-antora-tutorials/pull/22#discussion_r2430289219


##########
modules/ROOT/pages/tutorials/nbm-maven-modulesuite.adoc:
##########
@@ -150,28 +135,23 @@ In this tutorial you will create additional modules that 
will need to access the
 [start=1]
 1. Right-click the MyAPI project node and choose Properties to open the 
Properties window.
 
-[start=2]
-1. 
-Select the *com.mycompany.mavenselectionsuite* package in the *Public 
Packages* category:
-
-
-image::tutorials/maven-suite_72_pic5.png[title="screenshot"]
-
-Click OK.
 
+[start=2]
+1. Select the *com.mycompany.mavenselectionsuite* package in the *Public 
Packages* category:
++
+image::tutorials/maven-suite_270_pic5.png[title="screenshot"]
++
 When you select a package to export, the IDE modifies the  
``nbm-maven-plugin``  element in the *MyAPI* module's POM to specify the 
package:
-
-
++
 [source,xml]
 ----
-
 <plugin>
     <groupId>org.codehaus.mojo</groupId>
     <artifactId>nbm-maven-plugin</artifactId>
     <extensions>true</extensions>
     <configuration>
         <publicPackages>
-            *<publicPackage>com.mycompany.mavenselectionsuite</publicPackage>*

Review Comment:
   There's no visual difference, right? I checked some current examples (e.g. 
[annotations-lombok](https://github.com/apache/netbeans-antora-tutorials/blob/main/modules/ROOT/pages/kb/docs/java/annotations-lombok.adoc?plain=1#L182))
 and it's flat, no format.
   
   I personally find it more confusing than informative. The way to know the 
`*` is not part of the code is outside of the block itself... But you've been 
doing this for longer, if you really want it in I'll add it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to