mbien commented on code in PR #8733:
URL: https://github.com/apache/netbeans/pull/8733#discussion_r2368628409
##########
platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-Java-tokenColorings.xml:
##########
@@ -37,18 +37,18 @@
<fontcolor name="mod-annotation-type" default="identifier"/>
<fontcolor name="mod-annotation-type-declaration"
default="identifier"><font style="bold"/></fontcolor>
<fontcolor name="mod-class" default="identifier"/>
- <fontcolor name="mod-class-declaration" default="identifier"/>
+ <fontcolor name="mod-class-declaration" default="identifier"><font
style="bold"/></fontcolor>
<fontcolor name="mod-constructor" default="identifier"/>
- <fontcolor name="mod-constructor-declaration" default="identifier"/>
+ <fontcolor name="mod-constructor-declaration" default="identifier"><font
style="bold"/></fontcolor>
Review Comment:
I mentioned it in the PR text. The color is bright, and bright bold is not
great for dark themes. The bright parts are usually kept thin, no bright
backgrounds too etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
