lahodaj commented on code in PR #8897:
URL: https://github.com/apache/netbeans/pull/8897#discussion_r2446975324
##########
ide/lsp.client/test/unit/src/org/netbeans/modules/lsp/client/debugger/DebuggerTest.java:
##########
@@ -125,7 +125,8 @@ private static void nestedPrint(String toPrint) { //10
.addConfiguration(Map.of("type", "java+",
"request", "launch",
"file",
FileUtil.toFile(testFile).getAbsolutePath(),
- "classPaths", List.of("any")))
+ "classPaths", List.of("any"),
+ "testRun", false))
Review Comment:
I suspect the current proposed state goes a little bit too far. Unless
there's a proof the given class is a main class/has a main method, it will use
the test actions to run the file. As I said, I don't know what is the state
with Gradle, but for other project types, this is likely to fail, as they don't
support test actions outside of the test roots.
I suspect a hybrid approach would work better: for stuff outside of test
roots, use the non-test actions. For stuff in test roots, look at whether the
given class has a main method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
