mbien commented on PR #8959: URL: https://github.com/apache/netbeans/pull/8959#issuecomment-3448472002
> after https://github.com/apache/netbeans/pull/8756 was merged. I believe existence of such a functionality doesn't make https://github.com/apache/netbeans/pull/8756 obsolete and thus I am proceeding as agreed to I think its worth pointing out that the PR was merged without approval which would usually indicate integration readiness or some kind of consensus between the participating reviewers. I still think it would have been good to explore some (pure java) init-profile based solutions which are common for situations like this. As mentioned before, they are the standard way how to initialize a terminal and more flexible without having to modify the user's PATH variable. ```bash $ cat nb_profile echo "Welcome to the NB Terminal" alias nb='echo blabla...' $ bash --init-file <(cat /etc/profile ~/.bashrc nb_profile) Welcome to the NB Terminal $ nb blabla... ``` More flexibility provided by profiles might be needed, since users will soon ask why does `javac` not point to the default JDK and `mvn` doesn't run the bundled maven etc. If PATH concatenation is needed after all, the `nb_profile` file would be able to do that too as opt-in and it would be fully transparent and configurable by the user. While I don't like how this was handled I don't care enough to veto this, so I leave it at -0.9 and won't participate in the maintenance of this feature. Removing myself from the reviewers list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
