Achal1607 opened a new pull request, #9005: URL: https://github.com/apache/netbeans/pull/9005
Fixes crashes and incorrect behavior when resolving completion items across different javac contexts. When completion items are created, they capture Element references from the initial javac context. Later, when the LSP client calls `completionItem/resolve` to fetch `additionalTextEdits`, a new javac context may be used (especially if the file was modified). The old Element instances are invalid in the new context, causing `Assertion Error rootPackage missing!; currModule: java.base`. So, store ElementHandles instead of stale Elements when creating completion items. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
