pepness commented on code in PR #9072:
URL: https://github.com/apache/netbeans/pull/9072#discussion_r2600367531
##########
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ServerDetails.java:
##########
@@ -566,15 +566,26 @@ public enum ServerDetails {
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/7.0.25/glassfish-7.0.25.zip";,
// NOI18N
"http://www.eclipse.org/legal/epl-2.0"; //NOI18N
),
+
+ /**
+ * details for an instance of GlassFish Server 7.1.0
+ */
+ GLASSFISH_SERVER_7_1_0(NbBundle.getMessage(ServerDetails.class,
"STR_710_SERVER_NAME", new Object[]{}), // NOI18N
+ GlassfishInstanceProvider.JAKARTAEE10_DEPLOYER_FRAGMENT,
+ GlassFishVersion.GF_7_1_0,
+
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/7.1.0/glassfish-7.1.0.zip";,
// NOI18N
+
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/7.1.0/glassfish-7.1.0.zip";,
// NOI18N
+ "http://www.eclipse.org/legal/epl-2.0"; //NOI18N
+ ),
/**
* details for an instance of GlassFish Server 8.0.0
*/
GLASSFISH_SERVER_8_0_0(NbBundle.getMessage(ServerDetails.class,
"STR_800_SERVER_NAME", new Object[]{}), // NOI18N
GlassfishInstanceProvider.JAKARTAEE11_DEPLOYER_FRAGMENT,
GlassFishVersion.GF_8_0_0,
-
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M12.zip";,
// NOI18N
-
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M12.zip";,
// NOI18N
+
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M14.zip";,
// NOI18N
Review Comment:
Missing M12 to M14 change
##########
enterprise/glassfish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/admin/AdminFactoryTest.java:
##########
@@ -165,15 +165,15 @@ public void testGetInstanceforVersionGF6() {
}
/**
- * Test factory functionality for GlassFish v. 7.0.25
+ * Test factory functionality for GlassFish v. 7.1.0
Review Comment:
Better reverse this to GlassFish version 7.0.25 and create a new test
`testGetInstanceforVersionGF71()`, as this is a medium update going from 7.0.X
to 7.Y.X.
##########
enterprise/glassfish.tooling/src/org/netbeans/modules/glassfish/tooling/server/config/GlassFishV7_1_0.xml:
##########
@@ -0,0 +1,94 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<server>
+ <tools lib="lib">
+ <asadmin jar="client/appserver-cli.jar"/>
+ </tools>
+ <java version="21">
+ <platform version="17"/>
+ <platform version="18"/>
+ <platform version="19"/>
+ <platform version="20"/>
+ <platform version="21"/>
+ <platform version="22"/>
+ <platform version="23"/>
+ <platform version="24"/>
+ <platform version="25"/>
+ </java>
+ <javaee version="10.0.0">
+ <profile version="10.0.0" type="web"/>
+ <profile version="10.0.0" type="full" check="full"/>
+ <module type="war"/>
+ <module type="car" check="full"/>
+ <module type="ear" check="full"/>
+ <module type="ejb" check="full"/>
+ <module type="rar" check="full"/>
+ <check name="full">
+ <file path="appclient-server-core.jar"/>
+ </check>
+ </javaee>
+ <library id="Java EE">
+ <classpath>
+ <fileset dir="modules">
+ <include name="jakarta\..+\.jar"/>
+ <include name="jakarta.enterprise.cdi-api.jar"/>
+ <include name="jakarta.validation-api.jar"/>
+ <include name="jaxb-osgi.jar"/>
+ <include name="webservices-osgi.jar"/>
+ <include name="weld-osgi-bundle.jar"/>
+ </fileset>
+ <fileset dir="modules/endorsed">
+ <include name=".+\.jar"/>
+ </fileset>
+ </classpath>
+ <javadocs>
+ <lookup path="docs/jakartaee10-doc-api.jar"/>
+ </javadocs>
+ <sources>
+ </sources>
+ </library>
+ <library id="Jersey 3">
+ <classpath>
+ <fileset dir="modules">
+ <include name="jackson.+\.jar"/>
+ <include name="jersey.+\.jar"/>
+ <include name="jettison.*\.jar"/>
+ </fileset>
+ </classpath>
+ <javadocs>
+ <link
url="https://repo.maven.apache.org/maven2/org/glassfish/jersey/jersey-documentation/3.1.10/jersey-documentation-3.1.10-docbook.zip"/>
Review Comment:
Should be version 3.1.11
##########
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ServerDetails.java:
##########
@@ -566,15 +566,26 @@ public enum ServerDetails {
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/7.0.25/glassfish-7.0.25.zip";,
// NOI18N
"http://www.eclipse.org/legal/epl-2.0"; //NOI18N
),
+
+ /**
+ * details for an instance of GlassFish Server 7.1.0
+ */
+ GLASSFISH_SERVER_7_1_0(NbBundle.getMessage(ServerDetails.class,
"STR_710_SERVER_NAME", new Object[]{}), // NOI18N
+ GlassfishInstanceProvider.JAKARTAEE10_DEPLOYER_FRAGMENT,
+ GlassFishVersion.GF_7_1_0,
+
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/7.1.0/glassfish-7.1.0.zip";,
// NOI18N
+
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/7.1.0/glassfish-7.1.0.zip";,
// NOI18N
+ "http://www.eclipse.org/legal/epl-2.0"; //NOI18N
+ ),
/**
* details for an instance of GlassFish Server 8.0.0
*/
GLASSFISH_SERVER_8_0_0(NbBundle.getMessage(ServerDetails.class,
"STR_800_SERVER_NAME", new Object[]{}), // NOI18N
GlassfishInstanceProvider.JAKARTAEE11_DEPLOYER_FRAGMENT,
GlassFishVersion.GF_8_0_0,
-
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M12.zip";,
// NOI18N
-
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M12.zip";,
// NOI18N
+
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M14.zip";,
// NOI18N
+
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M14.zip";,
// NOI18N
Review Comment:
Missing M12 to M14 change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
