troizet opened a new pull request, #9074: URL: https://github.com/apache/netbeans/pull/9074
Added `CSS` embedding to `heredoc/nowdoc`. Partially implements feature request #5010. Before: <img width="345" height="244" alt="before" src="https://github.com/user-attachments/assets/4f0dce70-5771-4c75-8f0b-c3ec452559c4"; /> After: <img width="414" height="260" alt="after" src="https://github.com/user-attachments/assets/3fc3f06d-c6eb-4b19-8082-f792826207ac"; /> <img width="566" height="398" alt="css_autocomplete" src="https://github.com/user-attachments/assets/a1170c93-039b-40a2-ac59-56feb3685ea3"; /> <img width="921" height="251" alt="css_embedding_background_coloring" src="https://github.com/user-attachments/assets/cabe10c5-1881-4a89-a50a-796ace8afeea"; /> Based on discussion #7933, I was able to piece together the puzzle and add `CSS` embedding to `heredoc` and `nowdoc`. The `CssEmbeddingProvider` and test code is borrowed from the `Javascript2 VUE` module. The background highlighting code is borrowed from the `HTML Editor` module. I also encountered a formatter execution order issue, which was described by @matthiasblaesing in commit be093c3486ff0b9858aea8b2274ca646f87d48c6. I solved this issue by adding a hack to [TaskHandler.java](https://github.com/apache/netbeans/blob/master/ide/editor.indent/src/org/netbeans/modules/editor/indent/TaskHandler.java): https://github.com/troizet/netbeans/blob/f9f1f9fe22e4a46f4910a476449725c4a72fbb7f/ide/editor.indent/src/org/netbeans/modules/editor/indent/TaskHandler.java#L170-L186 --- **^Add meaningful description above** <details open> <summary>Click to collapse/expand PR instructions</summary> By opening a pull request you confirm that, unless explicitly stated otherwise, the changes - - are all your own work, and you have the right to contribute them. - are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information). Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field. If you're a first time contributor, see the Contributing guidelines for more information. If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run. ### PR approval and merge checklist: 1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)), did the right tests run? When did they run? 2. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)? 3. [ ] Are author name / email address correct? Are [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates? 3. [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes? If this PR targets the delivery branch: [don't merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery). ([full wiki article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide)) </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
