lahodaj commented on code in PR #9062:
URL: https://github.com/apache/netbeans/pull/9062#discussion_r2618450454
##########
java/java.editor/src/org/netbeans/modules/java/editor/imports/JavaFixAllImports.java:
##########
@@ -104,7 +104,6 @@ public static JavaFixAllImports getDefault() {
/** Creates a new instance of JavaFixAllImports */
private JavaFixAllImports() {
}
-
Review Comment:
Nit: revert this removal.
##########
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/OrganizeImportsCodeAction.java:
##########
@@ -30,6 +30,7 @@
import org.eclipse.lsp4j.WorkspaceEdit;
Review Comment:
The changes in this file do not seem to be necessary - these can be removed.
##########
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/CodeActionsProvider.java:
##########
@@ -49,7 +49,7 @@
* @author Dusan Balek
*/
public abstract class CodeActionsProvider {
-
+ public static final String FIX_IMPORTS_KIND = "source.fixImports";
Review Comment:
I suspect this should be moved to
`java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/FixImportsCodeAction.java`?
(I think that's consistent with what is being done for other ordinary
implementations of `CodeActionsProvider`s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
