BradWalker commented on PR #9096: URL: https://github.com/apache/netbeans/pull/9096#issuecomment-3677913155
> Thank you for the update. I still think this is a behavioral difference. I notice, that there is already synchronization in place in the `addExecutionListener` and `removeExecutionListener` methods. The `fireExecutionStarted` and `fireExecutionFinished` methods now have synchronization. If one of the execution listeners runs slow, it might now block another thread that tries to register or remove an execution listener. Hey Matthias, I think that I understand what you're saying. And I mostly agree. Yes, you are correct. This is probably a behavioral difference. My opinion would be that other behavior impacted should account for this as that would be proper s/w design. Having said that, the use of the clone() method is general disfavored. So what I changed it to do is make a shallow copy of the Set and iterate on that. Same behavior as before, yet removes the SuppressedWarnings message and cleans up the code a little bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
