mbien commented on code in PR #6112:
URL: https://github.com/apache/netbeans/pull/6112#discussion_r2652269663
##########
java/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/provider/Provider.java:
##########
@@ -260,7 +260,7 @@ public String getTableGenerationDropCreateValue(){
/**
* @return Map{@code <String, String>} containing vendor specific
properties.
*/
- public abstract Map getUnresolvedVendorSpecificProperties();
+ public abstract Map<String, String>
getUnresolvedVendorSpecificProperties();
Review Comment:
the implementations should be also updated, otherwise it becomes an
unchecked conversion warning there
##########
platform/openide.filesystems/src/org/openide/filesystems/XMLFileSystem.java:
##########
Review Comment:
@matthiasblaesing Handler is package private and I don't see the constructor
in the sig file. I suppose this means package private inner classes aren't
exported?
constructor could be changed to:
```java
Handler(Map<String, String> dtdMap, ResourceElem rootElem, boolean
validate) {
```
the now redundant cast in L1277 should be now also removed
```
String publicURL = (String) dtdMap.get(pid);
->
String publicURL = dtdMap.get(pid);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
