jtulach commented on code in PR #9142:
URL: https://github.com/apache/netbeans/pull/9142#discussion_r2772203723
##########
java/debugger.jpda.truffle/src/org/netbeans/modules/debugger/jpda/truffle/TruffleDebugManager.java:
##########
@@ -59,43 +59,50 @@
*/
@DebuggerServiceRegistration(types=LazyDebuggerManagerListener.class)
public class TruffleDebugManager extends DebuggerManagerAdapter {
-
+
private static final Logger LOG =
Logger.getLogger(TruffleDebugManager.class.getName());
-
+
private static final String ENGINE_CLASS = "org.graalvm.polyglot.Engine";
// NOI18N
private static final String ENGINE_BUILDER_CLASS =
"org.graalvm.polyglot.Engine$Builder"; // NOI18N
+ private static final String POLY_IMPL_CLASS =
"com.oracle.truffle.polyglot.PolyglotImpl"; // NOI18N
+ private static final String POLY_IMPL_BUILD_METHOD = "buildEngine"; //
NOI18N
Review Comment:
> test if `PolyglotImpl.buildEngine()` is there and if yes then use it, if
not then fall back to the public method.
That's would be optimal and robust! Now I just need to find out how to test
for existence of a method in the debuggee?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
