mbien commented on PR #9151: URL: https://github.com/apache/netbeans/pull/9151#issuecomment-3899251436
> > And could we move the -J-Dbootstrap.disableJDKCheck=true under a TODO there too? > > will either add TODOs or check if those added in [d0793ac](https://github.com/apache/netbeans/commit/d0793acdbd4b9ddd764c5ce8484cf021e8c38a9d) are still needed and maybe remove some. looks like I cleaned some of them up already, there are only two remaining: https://github.com/apache/netbeans/blob/bf4900bac4ed0d9222bfbcc56871b9b426ec3503/apisupport/apisupport.ant/test/unit/src/org/netbeans/modules/apisupport/project/suite/BuildZipDistributionTest.java#L236 https://github.com/apache/netbeans/blob/bf4900bac4ed0d9222bfbcc56871b9b426ec3503/platform/autoupdate.services/test/unit/src/org/netbeans/modules/autoupdate/services/NewClustersRebootTest.java#L96 the first can be removed when the ant modules are updated https://github.com/apache/netbeans/issues/7871 and I believe we can remove the second occurrence right now - at least tests work locally. Will add another commit and try - some modules have non obvious test invocation relationships. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
