matthiasblaesing commented on code in PR #9217:
URL: https://github.com/apache/netbeans/pull/9217#discussion_r2838437422
##########
contrib/websvc.wsitconf/src/org/netbeans/modules/websvc/wsitconf/ui/service/subpanels/KeystorePanel.java:
##########
@@ -375,7 +375,7 @@ private void
loadkeysButtonActionPerformed(java.awt.event.ActionEvent evt) {//GE
private void
keystoreLocationButtonActionPerformed(java.awt.event.ActionEvent evt)
{//GEN-FIRST:event_keystoreLocationButtonActionPerformed
JFileChooser chooser = new JFileChooser();
- FileUtil.preventFileChooserSymlinkTraversal(chooser, null);
+ chooser.setCurrentDirectory(null);
Review Comment:
Please move this to the else branch of the if-block starting in line 384
##########
contrib/j2ee.jboss4/src/org/netbeans/modules/j2ee/jboss4/customizer/CustomizerSupport.java:
##########
@@ -604,7 +604,7 @@ public void actionPerformed(ActionEvent e) {
private void addPathElement () {
JFileChooser chooser = new JFileChooser();
- FileUtil.preventFileChooserSymlinkTraversal(chooser, null);
+ chooser.setCurrentDirectory(null);
Review Comment:
I suggest to remove here and change 633-634 to read:
```java
chooser.setCurrentDirectory(this.currentDir != null &&
currentDir.exists() ? this.currentDir : null);
```
Else there are two code paths calling to `setCurrentDirectory`
##########
enterprise/j2ee.ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/ui/customizer/CustomizerSources.java:
##########
@@ -433,7 +433,7 @@ public void actionPerformed(java.awt.event.ActionEvent evt)
{
private void jButtonBrowseActionPerformed(java.awt.event.ActionEvent evt)
{//GEN-FIRST:event_jButtonBrowseActionPerformed
JFileChooser chooser = new JFileChooser();
- FileUtil.preventFileChooserSymlinkTraversal(chooser, null);
+ chooser.setCurrentDirectory(null);
Review Comment:
Shouldn't this be covered by 441+443?
##########
enterprise/j2ee.clientproject/src/org/netbeans/modules/j2ee/clientproject/ui/wizards/PanelSourceFolders.java:
##########
@@ -399,7 +399,7 @@ private void
jButtonLibrariesActionPerformed(java.awt.event.ActionEvent evt) {//
private void
jButtonConfigFilesLocationActionPerformed(java.awt.event.ActionEvent evt)
{//GEN-FIRST:event_jButtonConfigFilesLocationActionPerformed
JFileChooser chooser = new JFileChooser();
- FileUtil.preventFileChooserSymlinkTraversal(chooser, null);
+ chooser.setCurrentDirectory(null);
Review Comment:
Same situation as 387.
##########
enterprise/j2ee.clientproject/src/org/netbeans/modules/j2ee/clientproject/ui/wizards/PanelSourceFolders.java:
##########
@@ -384,7 +384,7 @@ public void actionPerformed(java.awt.event.ActionEvent evt)
{
private void jButtonLibrariesActionPerformed(java.awt.event.ActionEvent
evt) {//GEN-FIRST:event_jButtonLibrariesActionPerformed
JFileChooser chooser = new JFileChooser();
- FileUtil.preventFileChooserSymlinkTraversal(chooser, null);
+ chooser.setCurrentDirectory(null);
Review Comment:
Is this required with 390 setting current directory implictly and 392
explicitly?
##########
enterprise/j2ee.ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/ui/wizards/PanelSourceFolders.java:
##########
@@ -400,7 +400,7 @@ private void
jButtonLibrariesActionPerformed(java.awt.event.ActionEvent evt) {//
private void
jButtonConfigFilesLocationActionPerformed(java.awt.event.ActionEvent evt)
{//GEN-FIRST:event_jButtonConfigFilesLocationActionPerformed
JFileChooser chooser = new JFileChooser();
- FileUtil.preventFileChooserSymlinkTraversal(chooser, null);
+ chooser.setCurrentDirectory(null);
Review Comment:
`setSelectedFile` or `setCurrentDirectory` called below
##########
enterprise/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/sharability/ServerVolumeCustomizer.java:
##########
@@ -286,7 +286,7 @@ private void addResource(java.awt.event.ActionEvent evt)
{//GEN-FIRST:event_addR
baseFolder = new
File(URI.create(area.getLocation().toExternalForm())).getParentFile();
}
FileChooser chooser = new FileChooser(baseFolder, baseFolder);
- FileUtil.preventFileChooserSymlinkTraversal(chooser, null);
+ chooser.setCurrentDirectory(null);
Review Comment:
I suggest to move this into an else block for if started on 317
##########
contrib/websvc.wsitconf/src/org/netbeans/modules/websvc/wsitconf/ui/service/subpanels/TruststorePanel.java:
##########
@@ -335,7 +335,7 @@ private void
loadkeysButtonActionPerformed(java.awt.event.ActionEvent evt) {//GE
private void storeLocationButtonActionPerformed(java.awt.event.ActionEvent
evt) {//GEN-FIRST:event_storeLocationButtonActionPerformed
JFileChooser chooser = new JFileChooser();
- FileUtil.preventFileChooserSymlinkTraversal(chooser, null);
+ chooser.setCurrentDirectory(null);
Review Comment:
Please move to else block for if starting in line 344.
##########
enterprise/j2ee.ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/ui/wizards/PanelSourceFolders.java:
##########
@@ -385,7 +385,7 @@ public void actionPerformed(java.awt.event.ActionEvent evt)
{
private void jButtonLibrariesActionPerformed(java.awt.event.ActionEvent
evt) {//GEN-FIRST:event_jButtonLibrariesActionPerformed
JFileChooser chooser = new JFileChooser();
- FileUtil.preventFileChooserSymlinkTraversal(chooser, null);
+ chooser.setCurrentDirectory(null);
Review Comment:
`setSelectedFile` or `setCurrentDirectory` called below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
