NicolaIsotta opened a new pull request, #9350: URL: https://github.com/apache/netbeans/pull/9350
This PR fixes the evaluation of the default name for CDI beans to strictly align with the CDI specifications. Quoting [CDI 1.1 specs](https://docs.jboss.org/cdi/spec/1.1/cdi-spec.html#managed_bean_name): > The default name for a managed bean is the unqualified class name of the bean class, after converting the first character to lower case. > For example, if the bean class is named `ProductList`, the default bean name is `productList`. Subsequent specifications all maintain the exact same text. Here is the latest: [Jakarta EE CDI 4.1](https://jakarta.ee/specifications/cdi/4.1/jakarta-cdi-spec-4.1#managed_bean_name). ### Historical Notes I'm not exactly sure why the behavior was originally changed. My guess is that some implementations weren't perfectly aligned with the specifications at the time. For historical context on the deviation, see: - [NetBeans Bugzilla Issue #249438](https://bz.apache.org/netbeans/show_bug.cgi?id=249438) - [Related StackOverflow discussion](https://stackoverflow.com/questions/19414709/cant-find-named-cdi-bean-with-default-name-in-el-facelet) NB: this targets master but I'll gladly rebase to delivery if needed --- **^Add meaningful description above** <details open> <summary>Click to collapse/expand PR instructions</summary> By opening a pull request you confirm that, unless explicitly stated otherwise, the changes - - are all your own work, and you have the right to contribute them. - are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information). Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field. If you're a first time contributor, see the Contributing guidelines for more information. If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run. ### PR approval and merge checklist: 1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)), did the right tests run? When did they run? 2. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)? 3. [ ] Are author name / email address correct? Are [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates? 3. [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes? If this PR targets the delivery branch: [don't merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery). ([full wiki article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide)) </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
