matthiasblaesing commented on code in PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#discussion_r3236935473
##########
enterprise/maven.jaxws/src/org/netbeans/modules/maven/jaxws/MavenModelUtils.java:
##########
@@ -689,14 +688,12 @@ private static String getJaxWsVersion(Profile profile) {
}
/**
- * Get {@code Profile} to use when generating the web service client, the
- * {@code Profile} will be computed every time there is a call to
- * {@code hasJaxWsAPI}.
+ * Get {@code Profile} to use when generating the web service client.
* @param project
- * @see hasJaxWsAPI
*/
- private static void getProfile(Project project) {
+ public Profile getProfile(Project project) {
Review Comment:
Unless I'm mistaken, `getProfile` can stay static as there is no state other
than what is stored in `project` that is passed in. The instances created in
the `*Creator` classes can be dropped and replaced with a static call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
