jkovalsky commented on code in PR #79:
URL: https://github.com/apache/netbeans-tools/pull/79#discussion_r3244237700
##########
pp3/module/Application/src/Application/Entity/Plugin.php:
##########
@@ -203,4 +203,17 @@ private function sanitizePluginUrl($url) {
return $url;
}
+ public function getVersionsSorted($desc = true) {
Review Comment:
Well, we can leave this parametrized sorting in case community prefers the
other order in the future. In such case at least consider removing the
unnecessary "true" parameters in the function calls in:
- pp3/module/Application/view/application/index/catalogue.phtml
- pp3/module/Application/view/application/plugin/_plugin-listrow.phtml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
