NicolaIsotta commented on code in PR #9449:
URL: https://github.com/apache/netbeans/pull/9449#discussion_r3445714138
##########
nb/o.n.upgrader/src/org/netbeans/upgrade/CopyFiles.java:
##########
@@ -232,6 +256,79 @@ private EditableProperties getProperties(String
relativePath) throws IOException
return properties;
}
+ /**
+ * Copies var/attributes.xml, filtering to keep only fileobject entries
that
+ * contain an AuxilaryConfiguration attribute.
+ *
+ * @param sourceFile source attributes.xml
+ * @param targetFile target attributes.xml
+ * @throws IOException if parsing or writing fails
+ */
+ private static void copyFilteredAttributesXml(File sourceFile, File
targetFile) throws IOException {
+ try {
+ DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
+
dbf.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd";,
false); //NOI18N
Review Comment:
done
##########
platform/core.ui/src/org/netbeans/core/ui/resources/layer.xml:
##########
@@ -780,7 +780,7 @@
<attr name="displayName"
bundlevalue="org.netbeans.core.ui.options.general.Bundle#General.Options.Export.displayName"/>
</file>
<file name="Other">
- <attr name="include" stringvalue="config/Preferences/.*"/>
+ <attr name="include"
stringvalue="config/Preferences/.*|var/attributes.xml"/>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
