neilcsmith-net commented on PR #9472: URL: https://github.com/apache/netbeans/pull/9472#issuecomment-4844655596
Only glanced at this. Generally looks good, but I have concerns about all the changes to JNA. I also wonder how many people are using JNA in the platform without an OSGi framework included. Are there other ways of ensuring the right bundle name is seen from the NetBeans module? Does using both manifest keys work (eg. `Bundle-SymbolicName` as well)??? Or adapt Netigso to also consider provides? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
