[ 
https://issues.apache.org/jira/browse/OFBIZ-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7982.
-------------------------------
       Resolution: Fixed
    Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1757986.

Thanks [~rishisolankii] and [~rohit.koushal] for your contribution.

> Enforce noninstantiability to ICalWorker class
> ----------------------------------------------
>
>                 Key: OFBIZ-7982
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7982
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: workeffort
>    Affects Versions: Trunk
>            Reporter: Rishi Solanki
>            Assignee: Arun Patidar
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-7982.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected static methods as private;
> {code}
>     - protected static Map<String, Object> 
> createConversionContext(HttpServletRequest request)
>     - protected static Date getLastModifiedDate(HttpServletRequest request) 
> throws GenericEntityException
>     - protected static boolean isValidRequest(HttpServletRequest request, 
> HttpServletResponse response) throws IOException 
>     - protected static void logInUser(HttpServletRequest request, 
> HttpServletResponse response) throws GenericServiceException, 
> GenericEntityException
>     - protected static void setupRequest(HttpServletRequest request, 
> HttpServletResponse response)
>     - protected static void writeResponse(ResponseProperties responseProps, 
> HttpServletRequest request, HttpServletResponse response, ServletContext 
> context) throws IOException
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to