[ https://issues.apache.org/jira/browse/OFBIZ-7264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498625#comment-15498625 ]
Jacopo Cappellato commented on OFBIZ-7264: ------------------------------------------ While I agree that the changes proposed in this patch should be committed, it would be useful to double check if any of the client code that is modified was performing a null check on the cart object: if this is the case, then we should either remove the redundant check or do not modify the client code if the logic in case of a null cart object is relevant: I am saying this because getCartObject will actually create a new cart if one is not found while request.getAttribute("shoppingCart") obviously doesn't. > Use ShoppingCartEvents.getCartObject() to get shopping cart > ------------------------------------------------------------ > > Key: OFBIZ-7264 > URL: https://issues.apache.org/jira/browse/OFBIZ-7264 > Project: OFBiz > Issue Type: Improvement > Reporter: Deepak Dixit > Assignee: Jacopo Cappellato > Attachments: OFBIZ-7264.patch > > > As per current code base in many places shoppingcart is get directly from > session, we have method getCartObject() in ShoppingCartEvetns.java to get the > shoppingcart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)