[ 
https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851242#comment-15851242
 ] 

Taher Alkhateeb commented on OFBIZ-9182:
----------------------------------------

I don't think you got what I said about the two ways to pull (externals is not 
related here). I'll try to explain some more the benefits of the approach in 
the patch.
- First of all, the pullPluginSource won't stop you from using subversion if 
you want to. It's just a convenience task
- In the first implementation way I described above, you need svn installed, in 
the second you don't
- also using my patch we do not rely on a specific version control system. We 
can change it by changing implementation of pullPluginSource
- with pullPluginSource we can easily add the logic to pull dependencies which 
we cannot do with raw subversion. The implementation is already there in 
"pullPlugin".
- activating / deactivating plugins (or any component) can be done using 
ofbiz-component.xml. I don't understand why component-load.xml is needed in 
your argument above.

Anyway, If you want to change the implementation then open this discussion in 
the ML

> create a separate svn repository for OFBiz official plugins
> -----------------------------------------------------------
>
>                 Key: OFBIZ-9182
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9182
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Upcoming Release
>            Reporter: Taher Alkhateeb
>            Priority: Minor
>              Labels: gradle, plugins, subversion
>         Attachments: OFBIZ-9182-subversion-embedded.patch
>
>
> This issue is related to the discussion found in [this 
> thread|https://s.apache.org/aohk] in which the community approved 
> restructuring our repositories. To achieve this task the following needs to 
> be done (in this order)
> # Update the gradle scripts to assume that no plugins exist in the plugins 
> directory by default and no component-load.xml exists. It should follow the 
> same logic in loading the components as found in the ComponentContainer 
> class. Also the activation and deactivation of plugins happens in 
> ofbiz-component.xml, not in component-load.xml
> # Add a new task to gradle called pullPluginSource that retrieves a plugin 
> from subversion and defaults to the official plugins repository of Apache 
> OFBiz. This task mostly serve "Trunk" because it always needs the latest 
> source code of the plugins.
> # delete plugins/component-load.xml
> # move all plugins to a new repository called 
> http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins
> # move the core framework to a new repository called 
> http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework
> # fix buildbot to point to the new framework location
> # update documentation where applicable including README.md



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to