[ https://issues.apache.org/jira/browse/OFBIZ-9292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Brohl updated OFBIZ-9292: --------------------------------- Description: This file needs refactoring in several places: * possible NullPointerException(s) when accessing the VIEW_SIZE or VIEW_INDEX * catched NumberFormatException where it will not be thrown * hard codes messages instead of using translations * the transaction handling seems messy and has to be checked if necessary. (Why do we need inner transactions in a readonly functionality?) was: This file needs refactoring in several places: * possible NullPointerException(s) when accessing the VIEW_SIZE or VIEW_INDEX * catched NumberFormatException where it will not be thrown * hard codes messages instead of using translations > Refactor GetContentLookupList.groovy > ------------------------------------ > > Key: OFBIZ-9292 > URL: https://issues.apache.org/jira/browse/OFBIZ-9292 > Project: OFBiz > Issue Type: Improvement > Components: content > Affects Versions: Trunk > Reporter: Michael Brohl > Assignee: Michael Brohl > Priority: Minor > > This file needs refactoring in several places: > * possible NullPointerException(s) when accessing the VIEW_SIZE or VIEW_INDEX > * catched NumberFormatException where it will not be thrown > * hard codes messages instead of using translations > * the transaction handling seems messy and has to be checked if necessary. > (Why do we need inner transactions in a readonly functionality?) -- This message was sent by Atlassian JIRA (v6.3.15#6346)