[ https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044176#comment-16044176 ]
Devanshu Vyas edited comment on OFBIZ-9254 at 6/10/17 11:25 AM: ---------------------------------------------------------------- As per the discussion on the dev list, I have first prepared a patch(OFBIZ-9254_FTL-I.patch) which contains the fix for all the instances where .equals() method is used for comparisons in place of '==' in FTL files. was (Author: devanshu.vyas): As per the discussion on the dev list, I have first prepared a patch which contains the fix for all the instances where .equals() method is used for comparisons in place of '==' in FTL files. > Inconsistent String Comparisons > ------------------------------- > > Key: OFBIZ-9254 > URL: https://issues.apache.org/jira/browse/OFBIZ-9254 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Trunk > Reporter: Devanshu Vyas > Assignee: Deepak Dixit > Priority: Minor > Attachments: OFBIZ-9254_FTL-I.patch, > OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch, > OFBIZ-9254_java_accounting.patch, OFBIZ-9254_java_base.patch, > OFBIZ-9254_java_content.patch, OFBIZ-9254_java_entity.patch, > OFBIZ-9254_java_order.patch, OFBIZ-9254_java_Party_WE_MFC.patch, > OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch, > OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch, > OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch, > OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins_groovy.patch, > OFBIZ-9254_plugins_java.patch > > > I found an inconsistency in the code for string comparison > statusId.equals("PRUN_COMPLETED") whereas it should be written as > "PRUN_COMPLETED".equals(statusId) > cause the former can throw NullPointerException if the variable found to be > NULL. > This pattern should be applied to > - Java Files > - Groovy Files > - FTL Files > Here is the reference for the discussion done on the dev list. > http://markmail.org/message/iqfaab3fl3ukxchy -- This message was sent by Atlassian JIRA (v6.3.15#6346)