[ https://issues.apache.org/jira/browse/OFBIZ-9393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058976#comment-16058976 ]
Jacques Le Roux commented on OFBIZ-9393: ---------------------------------------- Martin said, bq. This approach also ensures that no other code needs a refactoring I agree, because all the old methods are automatically replaced with the new with Varargs ones. Just appy the patch and compile to be convinced. > UtilMisc.toMap(), toList() and toSet() refactoring taking Varargs for > creating the wanted data structure > -------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-9393 > URL: https://issues.apache.org/jira/browse/OFBIZ-9393 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: Trunk > Reporter: Martin Becker > Priority: Trivial > Attachments: OFBIZ-9393_UtilMiscOverloadedRefactoring.patch > > > This patch removes a number of outdated methods that took a fixed number of > objects to create a data structure, such as a linked list. Since the code is > outdated and inflexible, this patch removes these methods and added methods > to create the given data structure via a variable amount of arguments. This > approach also ensures that no other code needs a refactoring. In addition the > method populateMap() was removed which was private and was only used by the > multiple outdated toMap() functions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)