[ https://issues.apache.org/jira/browse/OFBIZ-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060815#comment-16060815 ]
Rishi Solanki commented on OFBIZ-9425: -------------------------------------- Just to confirm understanding with the ticket; - Service createShipment would create both sales and purchase shipment with workeffort. - For sales shipment it creates SHIPMENT_OUTBOUND type work effort and for purchase shipment it creates SHIPMENT_INBOUND type work effort. - The maps used in the patch shipWorkEffortMap used to create outbound work effort and arrivalWorkEffortMap used to create inbound shipment. - Which work effort will be created decided by the condition weather parameters.estimatedShipDate is coming or parameters.estimatedArrivalDate is coming. - With existing logic the workEffort.workEffortTypeId, workEffort.currentStatusId and workEffort.workEffortPurposeTypeId is not persist into db as values set into the wrong map. And now fixed in the patch. +1 for the fix and should be back ported to branches where it exists. > createShipment code logic error > ------------------------------- > > Key: OFBIZ-9425 > URL: https://issues.apache.org/jira/browse/OFBIZ-9425 > Project: OFBiz > Issue Type: Bug > Components: order > Affects Versions: Trunk > Reporter: Wai > Attachments: OFBIZ-9425.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)