[ https://issues.apache.org/jira/browse/OFBIZ-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079081#comment-16079081 ]
Deepak Dixit edited comment on OFBIZ-9408 at 7/8/17 11:04 AM: -------------------------------------------------------------- Hi Renuka, I reviewed your patch, it looks good to me. Here are some minor improvement that we can include: - Add existence check at freemarker side to avoid stack trace - I think instead of using uomInfo we can name it more appropriately like defaultUomWeight or defaultWeightUom etc - In WeightPackage.ftl you mix the weight uom and dimension. - I think we can use abbreviation instead of description. was (Author: deepak.dixit): Hi Renjuka, I reviewed your patch, it looks good to me. Here are some minor improvement that we can include: - Add existence check at freemarker side to avoid stack trace - I think instead of using uomInfo we can name it more appropriately like defaultUomWeight or defaultWeightUom etc - In WeightPackage.ftl you mix the weight uom and dimension. - I think we can use abbreviation instead of description. > Following uiLabels should move from ProductUiLabels.xml to > CommonEntityLabels.xml. > ---------------------------------------------------------------------------------- > > Key: OFBIZ-9408 > URL: https://issues.apache.org/jira/browse/OFBIZ-9408 > Project: OFBiz > Issue Type: Bug > Affects Versions: Trunk > Reporter: Renuka Srishti > Assignee: Deepak Dixit > Priority: Minor > Attachments: OFBIZ-9408.patch, OFBIZ-9408.patch, OFBIZ-9408.patch > > > Following uiLabels should move from ProductUiLabels.xml to > CommonEntityLabels.xml : > * ProductShipmentUomAbbreviation_LEN_in > * ProductShipmentUomAbbreviation_WT_g > * ProductShipmentUomAbbreviation_WT_kg > * ProductShipmentUomAbbreviation_WT_lb > These labels should be written in similer pattern as other labels of "Uom" > entity are written in CommonEntityLabels.xml, for example : > ProductShipmentUomAbbreviation_LEN_in will be written as > Uom.abbreviation.LEN_in > <entityName>.<fieldName>.<PrimaryKey> -- This message was sent by Atlassian JIRA (v6.4.14#64029)