[ https://issues.apache.org/jira/browse/OFBIZ-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-9563. ---------------------------------- Resolution: Implemented Fix Version/s: Upcoming Release Thanks Dennis, Your patch is in trunk at revision: 1804636 > [FB] Package org.apache.ofbiz.base.container > -------------------------------------------- > > Key: OFBIZ-9563 > URL: https://issues.apache.org/jira/browse/OFBIZ-9563 > Project: OFBiz > Issue Type: Sub-task > Components: base > Affects Versions: Trunk > Reporter: Dennis Balkir > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-No_org.apache.ofbiz.base.container_bugfixes.patch > > > - ComponentContainer.java:140, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE > RCN: Redundant nullcheck of componentLoadFile, which is known to be non-null > in > org.apache.ofbiz.base.container.ComponentContainer.loadComponentDirectory(String) > This method contains a redundant check of a known non-null value against the > constant null. > - ComponentContainer.java:165, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE > RCN: Redundant nullcheck of componentsToLoad, which is known to be non-null > in > org.apache.ofbiz.base.container.ComponentContainer.loadComponentsInDirectoryUsingLoadFile(File, > File) > This method contains a redundant check of a known non-null value against the > constant null. > - ComponentContainer.java:187, NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE > NP: Possible null pointer dereference in > org.apache.ofbiz.base.container.ComponentContainer.loadComponentsInDirectory(File) > due to return value of called method > The return value from a method is dereferenced without a null check, and the > return value of that method is one that should generally be checked for null. > This may lead to a NullPointerException when the code is executed. > - ContainerConfig.java:102, DLS_DEAD_LOCAL_STORE > DLS: Dead store to num in > org.apache.ofbiz.base.container.ContainerConfig.getPropertyValue(ContainerConfig$Configuration, > String, int) > This instruction assigns a value to a local variable, but the value is not > read or used in any subsequent instruction. Often, this indicates an error, > because the value computed is never used. > Note that Sun's javac compiler often generates dead stores for final local > variables. Because FindBugs is a bytecode-based tool, there is no easy way to > eliminate these false positives. > - ContainerConfig.java:135, DLS_DEAD_LOCAL_STORE > DLS: Dead store to num in > org.apache.ofbiz.base.container.ContainerConfig.getPropertyValue(ContainerConfig$Configuration$Property, > String, int) > This instruction assigns a value to a local variable, but the value is not > read or used in any subsequent instruction. Often, this indicates an error, > because the value computed is never used. > Note that Sun's javac compiler often generates dead stores for final local > variables. Because FindBugs is a bytecode-based tool, there is no easy way to > eliminate these false positives. -- This message was sent by Atlassian JIRA (v6.4.14#64029)