[ 
https://issues.apache.org/jira/browse/OFBIZ-9793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181015#comment-16181015
 ] 

Adam Heath commented on OFBIZ-9793:
-----------------------------------

This isn't as bad as the first-pass gradle integration; that added Labels 
files, and tons more properties files.  But there's still way too much.

If the reason to embed these files is to make the test system easier, then 
that's a stupid reason.  There are additional files of the same type of 
extension that are *not* being included(for instance, I see many other xsd 
files in other components), so the test system still needs to have the ofbiz 
checkout available. Which means the files can be read from their original 
locations.

Additionally, this broken behavior means there is a single global namespace for 
*all* files of a type. Each plugin(and baseline component) needs to have an 
isolated structure, within which it can't break other code.  All these embedded 
config files are placed at the root of the ofbiz.jar, which means it has a 
single namespace.

> Do *NOT* place config files into ofbiz.jar.
> -------------------------------------------
>
>                 Key: OFBIZ-9793
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9793
>             Project: OFBiz
>          Issue Type: Bug
>          Components: Gradle
>    Affects Versions: Trunk
>            Reporter: Adam Heath
>            Priority: Blocker
>
> Placing so many properties/xml stuff from each and every $component/config 
> makes it very very very difficult to provide deployment overrides, without 
> doing a full rebuild of the ofbiz.jar.  The deploy system should not be 
> running a build environment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to