[ https://issues.apache.org/jira/browse/OFBIZ-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368530#comment-16368530 ]
Taher Alkhateeb commented on OFBIZ-10195: ----------------------------------------- Hi Gil, I have reviewed the work again and did some testing which looks good so far. I have a few comments / questions though: * Have you considered putting the new attribute on the field level instead of the actual field type. So instead of putting it in the <text-find..> or whatever you put it in <field>. Would that pose a problem? Because it seems it might reduce the copy-paste pattern in the XSD files. * I suggest to rename "group-condition" to "condition-group". The first one implies a condition on a group, the second implies a group name to which a condition applies which sounds more correct. Looking forward to your feedback. > Add the ability in performFind service to set OR search criteria > ---------------------------------------------------------------- > > Key: OFBIZ-10195 > URL: https://issues.apache.org/jira/browse/OFBIZ-10195 > Project: OFBiz > Issue Type: Improvement > Reporter: Gil Portenseigne > Assignee: Gil Portenseigne > Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10195.patch, OFBIZ-10195.patch > > > When using performFind service for advanced entity search, we can meet the > need to have search criteria that do not intersect between them, but make the > union of the condition. > To realize this improvement we propose to set a new suffix _grp. > Thus using : > <field name="field1"><text-find/></field> > <field name="field1_grp"><hidden value="unionKey"/></field> > <field name="field2"><text-find/></field> > <field name="field2_grp"><hidden value="unionKey"/></field> > Then the two search fields criteria will be unioned during the search by the > OR operator. > Several different keys can be used for several different unioned condition. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)