[
https://issues.apache.org/jira/browse/OFBIZ-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538389#comment-16538389
]
Dennis Balkir commented on OFBIZ-10470:
---------------------------------------
Hi Aditya,
I forgot to describe the way to get there sorry.
If you follow the link I provided, then click on continue in the slaes order
screenlet.
After that, just click on order entry again, there should be more screenlets
now.
You will notice that the screenlet title "Create Sales Order" is done with an
{{h3}}, the screenlet titles for all screenlets inside the left container are
done with {{li}} and the other screenlet titles are done with {{div}}.
On the page you linked here this is shown:
{code:html}
screenlet-title-bar:
<div class="screenlet-title-bar">
<!-- No menu -->
<h1 | h2 | h3>Screenlet Title</h1 | h2 | h3>
</div>
<div class="screenlet-title-bar">
<!-- With menu -->
<ul>
<li class="h1 | h2 | h3">Screenlet Title</li>
<li> | <li class="disabled">Menu Item</li>
</ul>
</div>
{code}
So there is one missing in it, since there are 3 different kinds if titles in
use around OFBiz.
The main question would be, it at least one of them could be removed and
replaced by another one, or maybe two can be removed and replaced, since this
would create a more equal coding style all over OFBiz
> Inconsistent screenlet-title containers
> ---------------------------------------
>
> Key: OFBIZ-10470
> URL: https://issues.apache.org/jira/browse/OFBIZ-10470
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Dennis Balkir
> Priority: Minor
>
> Through the OFBiz-Backend there is some inconsistency in the use of
> screenlet-titles.
> The title is normally nested inside this:
> {code:html}
> <div class="screenlet">
> <div class="screenlet-title-bar">
> <!-- insert screenlet-title -->
> {code}
> But the title itself differs throughout the. backend quite often.
> As far as I have seen, there are 3 main kinds of title:
> # {code:html}
> <div class="screenlet">
> <div class="screenlet-title-bar">
> <div class="h3">Title</div>
> {code}
> # {code:html}
> <div class="screenlet">
> <div class="screenlet-title-bar">
> <h3>Title</h3>
> {code}
> # {code:html}
> <div class="screenlet">
> <div class="screenlet-title-bar">
> <ul>
> <li class="h3">Title</li>
> {code}
> All three variants can be found right here:
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
> ({{li}} is used in the {{left}}-container, {{h3}} is used for "Create Sales
> Order" and {{div}} is used for the other screenlets)
> Wouldn't it be better to limit this to one kind of container, and maybe style
> the differences (if wanted) through classes?
> Or maybe two containers, which then can be styled differently?
> The way it is now, with most of them looking the same anyway, it seems rather
> confusing than useful
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
