[ https://issues.apache.org/jira/browse/OFBIZ-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544212#comment-16544212 ]
Pradhan Yash Sharma commented on OFBIZ-10398: --------------------------------------------- +1 Looks good to me. > Rename deletePartyContactMechPurpose* services > ---------------------------------------------- > > Key: OFBIZ-10398 > URL: https://issues.apache.org/jira/browse/OFBIZ-10398 > Project: OFBiz > Issue Type: Improvement > Components: order, party > Affects Versions: Trunk > Reporter: Pierre Smits > Assignee: Suraj Khurana > Priority: Major > Attachments: OFBIZ-10398-rename.patch, OFBIZ-10398.patch > > > Both deletePartyContactMechPurposeIfExists and deletePartyContactMechPurpose > are misnomers, as these functions don't delete records but expires those by > setting the thruDate. The misnomers creates unnecessary confusion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)