[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558123#comment-16558123
]
Taher Alkhateeb commented on OFBIZ-10485:
-----------------------------------------
Third patch implemented in r1836710. Thank you for the feedback Mathieu. I
think I will lump together a few of the upcoming patches together due to their
simplicity and brevity, I'll share any questions I might have in here.
I have to mention that I really enjoy two things the most: refactoring and
declarative / functional coding. We have waaaay to many messy classes in base
and other framework components that I hope we get the chance to cleanup.
Thank you for your contributions, awesome work! Keep them coming!
> Refactor MapContext
> -------------------
>
> Key: OFBIZ-10485
> URL: https://issues.apache.org/jira/browse/OFBIZ-10485
> Project: OFBiz
> Issue Type: Improvement
> Components: base
> Reporter: Mathieu Lirzin
> Assignee: Taher Alkhateeb
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10485_0001-Remove-MapContext-dead-code.patch,
> OFBIZ-10485_0002-Add-missing-Override-in-MapContext.patch,
> OFBIZ-10485_0003-Use-the-Deque-interface-in-MapContext.patch,
> OFBIZ-10485_0004-Rewrite-MapContext-isEmpty.patch,
> OFBIZ-10485_0005-Rewrite-MapContext-containsKey.patch,
> OFBIZ-10485_0006-Rewrite-MapContext-keySet.patch,
> OFBIZ-10485_0007-Remove-MapContext.ListSet-class.patch,
> OFBIZ-10485_0008-Inline-MapContext-getMapContext.patch,
> OFBIZ-10485_0009-Rename-stackList-to-maps.patch,
> OFBIZ-10485_0010-Rework-comments.patch,
> OFBIZ-10485_0011-Add-entryStream.patch,
> OFBIZ-10485_0012-Add-withMapContainingKey.patch,
> OFBIZ-10485_0013-Rewrite-size.patch
>
>
> Following conversation
> [https://lists.apache.org/thread.htmlf1729ef5eafcf71adfbed0c3ea61dfb73225dff82abc4a57c3de8ed5@%3Cdev.ofbiz.apache.org%3E]
> on d...@ofbiz.apache.org.
> Here is a first batch of patches to clean things up. Those patches are meant
> to be applied in order.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
