[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577253#comment-16577253 ]
Mathieu Lirzin edited comment on OFBIZ-10515 at 8/11/18 5:33 PM: ----------------------------------------------------------------- Hello [~gil portenseigne], Nice work, this is working perfectly on my side minus the impersonation icon which fails to display for an unknown reason and is replaced by a text instead. I have a few cosmestic remarks regarding the Java code: - The {{impersonateLogin}} and {{depersonateLogin}} docstrings seem to not correspond with their implementation since they mention returning a boolean. - The indentation is going beyond the 120 char limit. Thanks was (Author: mthl): Hello [~gil portenseigne], Nice work, this is working perfectly on my side minus the impersonation icon which fails to display for an unknown reason and is replaced by a text instead. I have a few cosmestic remarks regarding Java code: - The {{impersonateLogin}} and {{depersonateLogin}} docstrings seem to not correspond with their implementation since they mention returning a boolean. - The indentation is going beyond the 120 char limit. Thanks > Impersonation of userLogin feature > ---------------------------------- > > Key: OFBIZ-10515 > URL: https://issues.apache.org/jira/browse/OFBIZ-10515 > Project: OFBiz > Issue Type: Improvement > Affects Versions: Trunk > Reporter: Gil Portenseigne > Assignee: Gil Portenseigne > Priority: Minor > Fix For: Upcoming Branch > > Attachments: ImpersonationWidget.png, OFBIZ-10515.patch, > impersonate-ico.png, impersonateButton.png > > > This JIRA introduce a new feature that allow the impersonation of a login by > an authorized user. > This is implemeted with :· > * A new service ‘userImpersonate’ that will check security, store > impersonation in UserLoginHistory, and return the new session > * Events ‘userImpersonate’ and ‘userDepersonate’ that will allow > impersonation/depersonation action persisting current user session > * A new modal widget in the common-theme that inform the user about > ‘impersonation in process’ and offering a way to depersonate. > * A new field in UserLoginHistory to store impersonation originator > * A button in party viewprofile page to illustrate the feature -- This message was sent by Atlassian JIRA (v7.6.3#76005)