[ https://issues.apache.org/jira/browse/OFBIZ-7113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607354#comment-16607354 ]
Nicolas Malin commented on OFBIZ-7113: -------------------------------------- Ohhh, effectively the commit 1818708 break this patch, I regenerate it after rebasing it on trunk. I also saw that I forgot to load my tests on the previous patch :) Now with this [^OFBIZ-7113.patch]it's ok ! > Refactoring permission model call > --------------------------------- > > Key: OFBIZ-7113 > URL: https://issues.apache.org/jira/browse/OFBIZ-7113 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: Trunk > Reporter: Nicolas Malin > Assignee: Nicolas Malin > Priority: Minor > Attachments: OFBIZ-7113.patch, OFBIZ-7113.patch, OFBIZ-7113.patch > > > With the subject on mailing list "Permission service not on the same > transaction" : http://markmail.org/message/34vxi4ntmbj7vzcr > I started the improvement but the java code need to be clean and refactoring. > I share my first draft patch, but need more works. I realize : > * unified call evalPermission > * move all related field for permission service on ModelService to > ModelPermission > * Remove deprecated code > * start labelized error message > * add new attributes on permission model : required-new-transaction and > return-error-on-failure -- This message was sent by Atlassian JIRA (v7.6.3#76005)