[
https://issues.apache.org/jira/browse/OFBIZ-9738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697736#comment-16697736
]
Saurabh Dixit commented on OFBIZ-9738:
--------------------------------------
The other equals methods in the ShoppingCartItem are utility methods whose
purpose is to find ShoppingCartItem with the provided values and keeping other
values default. There is also an equals method which takes a ShoppingCartItem
object and do the comparison with the other ShoppingCartItem object which I
think fulfills your purpose.
I can see in the code that these utility methods are never called from
anywhere. So, I think we don't need any change. You may share your further
thoughts on this.
> ShoppingCartItem equals method does not compare object references
> -----------------------------------------------------------------
>
> Key: OFBIZ-9738
> URL: https://issues.apache.org/jira/browse/OFBIZ-9738
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Trunk
> Reporter: Gareth Carter
> Assignee: Saurabh Dixit
> Priority: Minor
>
> The default Object class equals method checks for reference equality however
> ShoppingCartItem does not (I believe it should). When it filters down through
> the other equals methods some properties have a default value which could be
> different to the value stored in the object
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
