[
https://issues.apache.org/jira/browse/OFBIZ-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713720#comment-16713720
]
Pierre Smits commented on OFBIZ-10252:
--------------------------------------
Without a style guide it is hard to form an opinion on the matter. But simply
replacing one undescribed/unexplained element 'button-style-2' with one other
undescribed/unexplained element 'functional-button-bar' does add much value.
Also, as every button bar is functional a name like 'functional-button-bar'
does not help.
We also have to take into consideration that style guides vary per theme (and
the front-end framework applied by the theme). Currently we have the 'OFBiz'
way, applied to Common-Theme with deviation/variation thereon in Bluelight,
Flatgrey and Tomahawk themes and the E-commerce component themes EC_Default and
Multiflex. Then we have the Bootstrap oriented RainbowStone theme.
The impact downstream (on the themes, and their renderers) is inherent with
changing this.
> Making the use of the "button-style-2" class for backend menus consistent
> -------------------------------------------------------------------------
>
> Key: OFBIZ-10252
> URL: https://issues.apache.org/jira/browse/OFBIZ-10252
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Trunk
> Reporter: Dennis Balkir
> Priority: Minor
>
> While doing some work on the backend of OFBiz, I noticed, that in some cases
> the functional buttons of the application I am using are styled with the
> class "button-bar button-style-2" and in some other cases are only styled
> with "button-bar".
> Here are some suggenstions:
> * The use of the class "button-bar button-style-2" should be consistent
> * The class should get another name, "button-style-2" doesn't really fit its
> purpose, I would suggest to name the whole class "button-bar
> functional-button-bar"
> * If the class "button-style-2" is used for different buttons too, I would
> suggest making a new class "functional-button-bar"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
