[ https://issues.apache.org/jira/browse/OFBIZ-10847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788610#comment-16788610 ]
Lalit Dashora commented on OFBIZ-10847: --------------------------------------- Hi, Please find the attached patch. Fixed the issue of promotion discount when customer orders more than X amount in Y months. Changed compareBase variable to -1 since this was causing issue. Since the compareBase value was set to 1 and operatorEnumId is PPC_GTE, so promotion condition check was always returning true when compareBase value is greater than equal to 0. Thanks! > Issue in order history promotion > -------------------------------- > > Key: OFBIZ-10847 > URL: https://issues.apache.org/jira/browse/OFBIZ-10847 > Project: OFBiz > Issue Type: Bug > Components: product > Affects Versions: Upcoming Branch, Release Branch 18.12 > Reporter: Lalit Dashora > Assignee: Lalit Dashora > Priority: Major > Attachments: OFBIZ-10847.patch > > > Instance: [#https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > Reference promotion Id: 9019 > Promo Description: Spend more than $1000 in any 12 months on our fabulous > Widgets and Gizmos and get a 5% discount. > PromoName: Test Percent off when Customer Orders over $1000 in 12 months > Issue: According to the promotion customer should spend $1000 in any 12 > months to avail 5% discount. The system is providing the discount even if the > customer is not logged in. -- This message was sent by Atlassian JIRA (v7.6.3#76005)