[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847378#comment-16847378 ]
Swapnil M Mane commented on OFBIZ-10145: ---------------------------------------- +1 to commit, I have tested both the scripts on trunk and release17. Everything is working as expected for me. Thank you [~soledad] for your work and everyone for your comments. [~soledad] Just a small improvement, since now we are removing the corrupt archive, we should change the message from {code} echo "\nThe gradle-5.0-bin.zip file is corrupted.\nPlease remove this file from $OFBIZ_HOME/runtime/tmp location and run the script again." {code} to {code} echo "\nThe gradle-5.0-bin.zip file was corrupted thus it is removed from $OFBIZ_HOME/runtime/tmp location.\nNow please run the script again." {code} > Remove the Gradle wrapper from our release packages and add a step to our > build notes > ------------------------------------------------------------------------------------- > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle > Affects Versions: 17.12.01, 16.11.06, 18.12.01 > Reporter: Jacques Le Roux > Assignee: Nicolas Malin > Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)