[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866311#comment-16866311
 ] 

Jacques Le Roux commented on OFBIZ-10145:
-----------------------------------------

Hi Nicolas,

bq.  this introduce a hard rule for future to keep it during all time that a 
release version would be present on support.
You got a point there indeed. We will have to keep the versions which are used 
by Buildbot and the demo but no more. 

BTW, for them, instead of asking infra for help, we should now punctually use 
{{gradlew wrapper --gradle-version x.y.z}} in our scripts when necessary. Then 
Gradle will be automatically updated where it fits currently \o/

bq. After check a different solution I can suggest to download directly from 
official gradle source: 
https://github.com/gradle/gradle/tree/v5.0.0/gradle/wrapper and set the version 
'v5.0.0' in own source code.
I agree sounds better

I think we are ready now :)


> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10145
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10145
>             Project: OFBiz
>          Issue Type: Task
>          Components: Gradle
>    Affects Versions: 17.12.01, 16.11.06, 18.12.01
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Blocker
>             Fix For: 17.12.01
>
>         Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, 
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to