[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16869382#comment-16869382
]
Swapnil M Mane edited comment on OFBIZ-10145 at 6/21/19 10:56 AM:
------------------------------------------------------------------
Thanks so much [~jacques.le.roux] and [~soledad], this work is going in great
direction :)
I think, we should also have existance check for gradle-wrapper.properties file.
Here is the patch [^OFBIZ-10145_wrapper_properties_check.patch] for same,
please have a look.
Also, I am thinking about the use case, how we will change the
gradle-wrapper.jar and gradle-wrapper.properties on user's machine when we
upgrade our Gradle version in trunk.
E.g. currently we are using Gradle v5.0 on the trunk, in future when we upgrade
the Gradle to next version let say v5.4.1.
In this case, the gradle-wrapper.jar and gradle-wrapper.properties will be not
be updated on user's machine because as per our script it will only check the
files with name (gradle-wrapper.jar and gradle-wrapper.properties) should exist
in OFBiz_Root/gradle/wrapper directory.
And the script will found the old files in OFBiz_Root/gradle/wrapper directory,
thus will not download the new jar and properties files.
Please let me know if I am missing anything.
Thanks!
was (Author: swapnilmmane):
Thanks so much [~jacques.le.roux] and [~soledad], this work is going in great
direction :)
I think, we should also have existance check for gradle-wrapper.properties file.
Here is the patch [^OFBIZ-10145_wrapper_properties_check.patch] for same,
please have a look.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
> Affects Versions: 17.12.01, 16.11.06, 18.12.01
> Reporter: Jacques Le Roux
> Assignee: Nicolas Malin
> Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch,
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch,
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
